fix: swap out dets for sqlite3 #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes a bug with go to definition. it turns out that multiple references were being stored that overlapped in range, so we'd get multiple references, which didn't match the pattern, so it returned nil. Now, sqlite easily deletes any references that overlap with the one we are inserting in that moment.
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Sep 30, 2023
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: swap out dets for sqlite3
Also fixes a bug with go to definition. it turns out that multiple
references were being stored that overlapped in range, so we'd get
multiple references, which didn't match the pattern, so it returned nil.
Now, sqlite easily deletes any references that overlap with the one we
are inserting in that moment.